Skip to content

Fix Template.latest_version Ambiguity Error #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
+5 −1
Open

Fix Template.latest_version Ambiguity Error #3474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1262869
Fix `Template.latest_version` ambiguity error
aaronskiba Jan 13, 2025
3125bc9
Update CHANGELOG.md
aaronskiba Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
- Refactor Plan.deep_copy(plan) [#3469](https://github.com/DMPRoadmap/roadmap/pull/3469)
- Fixed a bug in the deep copy of plans where the old identifier was being copied into the new plan. We now copy the generated id of the new plan to the identifier field.
- Fixed bar chart click function in the Usage dashboard (GitHub issue #3443)

- Fix `Template.latest_version` Ambiguity Error [#3474](https://github.com/DMPRoadmap/roadmap/pull/3474)

**Note this upgrade is mainly a migration from Bootstrap 3 to Bootstrap 5.**

Expand Down
4 changes: 4 additions & 0 deletions app/models/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ class Template < ApplicationRecord
AND current.family_id = templates.family_id
INNER JOIN orgs ON orgs.id = templates.org_id
SQL
# `SELECT "templates.*"` is this scope's default behavior, but it must be explicitly
# specified to prevent `PG::AmbiguousColumn` errors when `.distinct.total_count` is used
# (e.g. in `app/views/layouts/_paginable.html.erb`)
.select('templates.*')
}

# Retrieves the latest customized versions, i.e. those with maximum version
Expand Down
Loading