Skip to content

Fix Handling of "Only Show Admins" Filter #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
+2 −1
Open

Fix Handling of "Only Show Admins" Filter #3473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14a013d
Ensure `filter_admin`param is consistently passed
aaronskiba Jan 9, 2025
2222162
Update CHANGELOG.md
aaronskiba Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Changelog

- Fix Handling of "Only Show Admins" Filter [#3473](https://github.com/DMPRoadmap/roadmap/pull/3473)
- Refactor Plan.deep_copy(plan) [#3469](https://github.com/DMPRoadmap/roadmap/pull/3469)
- Fixed a bug in the deep copy of plans where the old identifier was being copied into the new plan. We now copy the generated id of the new plan to the identifier field.
- Fixed bar chart click function in the Usage dashboard (GitHub issue #3443)
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/paginable/users_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def index
paginable_renderise(
partial: 'index',
scope: scope,
query_params: { sort_field: 'users.surname', sort_direction: :asc },
query_params: { sort_field: 'users.surname', sort_direction: :asc, filter_admin: params[:filter_admin] },
format: :json,
view_all: !current_user.can_super_admin?
)
Expand Down
Loading