add translation format for at_csv.rb and usage section#3235
Merged
pengyin-shan merged 6 commits intodevelopmentfrom Nov 29, 2022
Merged
add translation format for at_csv.rb and usage section#3235pengyin-shan merged 6 commits intodevelopmentfrom
pengyin-shan merged 6 commits intodevelopmentfrom
Conversation
pengyin-shan
changed the title
briri
approved these changes
Nov 16, 2022
Contributor
briri
left a comment
briri
left a comment
There was a problem hiding this comment.
looks good to me @pengyin-shan
| <p><%= _("Click below to give data management staff at #{plan.owner.org.name}, the Plan Owner's org, access to read and comment on your plan.") %></p> | ||
| <p> | ||
| <%= | ||
| _("Click below to give data management staff at %{owner_org}, the Plan Owner's org, access to read and comment on your plan.") % { |
Contributor
There was a problem hiding this comment.
Thanks for pulling that variable out of the string 👍🏻
benjaminfaure
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add translation format for csv headers and a few files in usage section