pluck with ampersand returns not id#3209
Merged
briri merged 1 commit intoDMPRoadmap:developmentfrom Aug 30, 2022
nicolasfranck:development
Merged
pluck with ampersand returns not id#3209briri merged 1 commit intoDMPRoadmap:developmentfrom nicolasfranck:development
briri merged 1 commit intoDMPRoadmap:developmentfrom
nicolasfranck:development
Conversation
briri
approved these changes
Aug 30, 2022
Contributor
briri
left a comment
briri
left a comment
There was a problem hiding this comment.
I think you're right @nicolasfranck probably a typo
Contributor
|
Tests are failing on the development branch (Rails 6) and we are aware, so merging this one even though the tests fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
plans.pluck(&:id)returns array of array values containing the plan attributes values. Probably typo. Should beplans.pluck(:id)