do not repeat help instructions for every guidance group#3173
Merged
briri merged 2 commits intoDMPRoadmap:developmentfrom Jun 3, 2022
nicolasfranck:fix_org_admin_multiple_theme_help
Merged
do not repeat help instructions for every guidance group#3173briri merged 2 commits intoDMPRoadmap:developmentfrom nicolasfranck:fix_org_admin_multiple_theme_help
briri merged 2 commits intoDMPRoadmap:developmentfrom
nicolasfranck:fix_org_admin_multiple_theme_help
Conversation
nicolasfranck
added a commit
to DMPbelgium/roadmap
that referenced
this pull request
May 12, 2022
nicolasfranck
added a commit
to DMPbelgium/roadmap
that referenced
this pull request
Jun 1, 2023
nicolasfranck
added a commit
to DMPbelgium/roadmap
that referenced
this pull request
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: if you open the template editor, in the org admin interface, and then open a question for editing,
you'll see some themed guidance next to that question.
If you have multiple guidance groups that match the theme
of the current question, then the help text
Click the links below to view organisational guidance related to the themes associated with this question.as many times.The cause is a missing break statement for the outer loop here
I believe the only reason for this loop was set to set variable
has_org_themed_guidancetotrue, right?In that case that one
breakis not enough, as there another outer loop also.I've moved that help text also too.
Unless of course, this has a different purpose.