DCC bug 711 - Fix for the Rest API call POST /api/v1/plans for Plan#3137
Merged
briri merged 1 commit intodevelopmentfrom Mar 31, 2022
Merged
Conversation
johnpinto1
force-pushed
the
dcc_bug_711-Creating_plans_using_V1_default_template_bug
branch
5 times, most recently
from
30e0cd1 to
46680f9
Compare
creation. The previous call based on instructions in wiki was always defaulting to using the default template regardless of template id sent. Fix for DCC bug 711 https://github.com/DigitalCurationCentre/DMPonline-Service/issues/711 The API Documentation V1 - Create Plan page has been changed "dmptool" replaced by "dmproadmap" in fragment of Json sent for plan creation. Changes: - We use :dmproadmap which is the symbol of the dmproadmap json object nested in extensions which is the container for the json template object, etc. - In app/services/api/v1/deserialization_service.rb the method app_extensions() has been changed to use the symbol :dmproadmap. - In app/views/api/v1/plans/_show.json.jbuilder the block that builds the template json object now uses the symbol :dmproadmap - fixed tests in spec/services/api/v1/contextual_error_service_spec.rb, spec/services/api/v1/deserialization_service_spec.rb and ./spec/views/api/v1/plans/_show.json.jbuilder_spec.rb.
johnpinto1
force-pushed
the
dcc_bug_711-Creating_plans_using_V1_default_template_bug
branch
from
46680f9 to
58c23e9
Compare
briri
deleted the
dcc_bug_711-Creating_plans_using_V1_default_template_bug
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
creation. The previous call based on instructions in wiki was always
defaulting to using the default template regardless of template id sent.
Fix for DCC bug 711 https://github.com/DigitalCurationCentre/DMPonline-Service/issues/711
The API Documentation V1 - Create Plan page has been changed
"dmptool" replaced by "dmproadmap" in fragment of Json sent for plan
creation.
Changes:
nested in extensions which is the container for the json template object, etc.
app_extensions() has been changed to use the symbol :dmproadmap.
the template json object now uses the symbol :dmproadmap
and spec/services/api/v1/deserialization_service_spec.rb.
The Extensions fragment in POST
Extension fragment in Response
