DCC Bug 711 - Fix for broken creation of a Plan using the V0 API.#3135
Merged
briri merged 4 commits intodevelopmentfrom Mar 31, 2022
Merged
DCC Bug 711 - Fix for broken creation of a Plan using the V0 API.#3135briri merged 4 commits intodevelopmentfrom
briri merged 4 commits intodevelopmentfrom
Conversation
Issue fixed DCC bug for /api/v0/plans for creating a Plan given a template id https://github.com/DigitalCurationCentre/DMPonline-Service/issues/711 Changes: - in app/controllers/api/v0/base_controller.rb: added strong parameters function plan_params. - in app/controllers/api/v0/plans_controller.rb: in method create() added @plan.org = @user.org and replaced @plan.assign_creator(plan_user) by @plan.add_user!(plan_user.id, :creator).
briri
approved these changes
Mar 31, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue fixed DCC bug for /api/v0/plans for creating a Plan given a
template id https://github.com/DigitalCurationCentre/DMPonline-Service/issues/711
Changes:
parameters function plan_params.
added
@plan.org = @user.org
and
replaced
@plan.assign_creator(plan_user)
by
@plan.add_user!(plan_user.id, :creator).