Added toggleable guidance/comments section#3123
Merged
briri merged 3 commits intoDMPRoadmap:developmentfrom Mar 11, 2022
Merged
Added toggleable guidance/comments section#3123briri merged 3 commits intoDMPRoadmap:developmentfrom
briri merged 3 commits intoDMPRoadmap:developmentfrom
Conversation
Contributor
Author
|
I wasn't sure where to put the CSS & JS code, if it's in the wrong place please tell me :) |
briri
requested changes
Mar 8, 2022
Contributor
briri
left a comment
There was a problem hiding this comment.
Thanks for getting this to us so quickly @benjaminfaure!
I have 2 very minor changes. It looks great overall and the JS and SCSS files are in the correct place! :)
I will pull down the changes and confirm that it works as expected in the UI later today
Contributor
Author
|
Thanks for your feedback @briri , I push the changes you requested :) |
Contributor
|
@benjaminfaure @briri Pulled down the code on top of an up to date roadmap and it worked perfectly out of the box. Very nice! So I'm for it to get merged in. |
briri
approved these changes
Mar 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR: