Issue#dcc2983 - Fix for preventing adding a Contributor via Contributor#3062
Closed
johnpinto1 wants to merge 1 commit intodevelopmentfrom
Closed
Issue#dcc2983 - Fix for preventing adding a Contributor via Contributor#3062johnpinto1 wants to merge 1 commit intodevelopmentfrom
johnpinto1 wants to merge 1 commit intodevelopmentfrom
Conversation
page if both Name and Email are not present. Fixes DCC bug #2983 Changes: - Changes in Contributor model: - Renamed validation method name_or_email_presence() -> name_and_email_presence() - Updated conditions in name_and_email_presence() method to return errors if Name or Email missing. - Updated tests in spec/models/contributor_spec.rb and spec/services/api/v1/contextual_error_service_spec.rb to reflect change in Contributor model.
johnpinto1
force-pushed
the
bug_DCC2983-possible_to_add_contributor_without_a_name
branch
from
2a3f695 to
26b4976
Compare
Contributor
Author
|
Ignore my previous comment on tests. I deleted comment and fixed broken test. |
Contributor
|
Yes, this will be problematic for us as we have many records where email was not provided. We only have a handful of records with a nil name, so I can manually address that one fairly easily. Maybe set this as an additional config flag like: |
Contributor
Author
|
@raycarrick-ed @briri Will close issue and re-open after finding a way of reconciling with @briri comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
page if both Name and Email are not present.
Fixes DCC bug #2983
spec/services/api/v1/contextual_error_service_spec.rb
Changes:
@briri Not sure if this conditionality is different for UC3.
(Away for a week so won't pick up until Nov 15th.)
Scrrenshots of different error scenarios:
