Issue #496 - Plan search issues.

[johnpinto1]

Fixes #496 .
The specification for Plans search and display was cited by @mariapraetzellis in comment
#3000 (comment)

We discussed this in our team meeting. @johnpinto1

My Dashboard - shows Plans the current user's currently has an 'active' role on (creator, co-owner, editor, commenter)

    agreed this is the correct behavior

My Dashboard - shows the organisationally visible plans for the current user
-- agreed this is the correct behavior

Admin -> Plans - shows all of the plans owned/co-owned by one of the Org's users

    agreed this is the correct behavior
    -there is an exception to this in the code that are two configurable settings that allows an instance to set this so private plans do not display for admins or super admins

Admin -> Users - shows the Plans for the user being edited (not sure if these are creator or would show if the user is just an editor or commenter)

    This is the correct behavior but we do have an additional feature to add as described below. We will make a new issue for this additional feature.
    We should add a new column that shows the user's role in each plan. This would also need to adhere to the configuration settings that allows an instance to set this so private plans do not display for admins or super admins.

Public Plans - shows any Plan marked as publicly_visible

    This is the correct behavior

We'd have to look at the API v0 and v1 to see if they use that search method (I think v0 might)

    Please check API v0 & V1 to make sure they're following the configuration settings

Further comments by @raycarrick-ed and @briri are linked here:
#3000 (comment)
#3000 (comment)

Changes proposed in this PR:

 - Replaced .where(Role.creator_condition) with .where(roles: { active: true })
 in model Plan search scope.
 - Added .where(roles: { active: true }) to Plan retrieval in
org_admin_plans() method of the Org model.  (@briri does this address comment https://github.com/DMPRoadmap/roadmap/pull/3000#issuecomment-901975844, as aPI only available to Org Admins.)

[johnpinto1]

Test Failure: Looks like error in difference in Plan content. No something I changed. Any ideas on fix

1) Org#org_admin_plans read_all is false, visibility public and user org_admin is expected to include #<Plan id: 85, title: "target frictionless synergies", template_id: 150, created_at: "2021-09-02 13:5... "http://murazik-breitenberg.com/rodger_kessler", funding_status: "funded", research_domain_id: nil>
     Failure/Error: it { is_expected.to include(plan) }

       expected #<ActiveRecord::Relation []> to include #<Plan id: 85, title: "target frictionless synergies", template_id: 150, created_at: "2021-09-02 13:5... "http://murazik-breitenberg.com/rodger_kessler", funding_status: "funded", research_domain_id: nil>
       Diff:
       @@ -1,2 +1,2 @@
       -[#<Plan id: 85, title: "target frictionless synergies", template_id: 150, created_at: "2021-09-02 13:58:37", updated_at: "2021-09-02 13:58:37", identifier: "48d81708995570bd2d04dcb05ebdd7d7", description: "Consequuntur earum adipisci. Nihil omnis accusamus...", visibility: "publicly_visible", feedback_requested: false, complete: false, org_id: 682, funder_id: nil, grant_id: nil, start_date: "2021-09-02 13:58:37", end_date: "2023-09-02 13:58:37", ethical_issues: true, ethical_issues_description: "Fugiat corrupti amet. Tempora et ratione. Corrupti...", ethical_issues_report: "http://murazik-breitenberg.com/rodger_kessler", funding_status: "funded", research_domain_id: nil>]

[briri]

My guess would be that the plan used in that test has an issue with the role(s) used. The test itself likely needs to be updated rather than it being an issue with your changes