Skip to content

fix issue with investigator and data_Contact info for API v0 #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raycarrick-ed merged 2 commits into from
May 6, 2021
Merged

fix issue with investigator and data_Contact info for API v0 #2892

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97e2eee
fix issue with investigator and data_Contact info for API v0
briri May 5, 2021
60b124b
make rubocop happy
briri May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions app/views/api/v0/plans/index.json.jbuilder
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,21 @@ json.array! @plans.each do |plan|
json.funder do
json.name(plan.template.org.funder? ? plan.template.org.name : plan.funder&.name)
end
json.principal_investigator do
investigator = plan.contributors.investigation.first

json.name investigator.name
json.email investigator.email
json.phone investigator.phone
investigator = plan.contributors.investigation.first
if investigator.present?
json.principal_investigator do
json.name investigator.name
json.email investigator.email
json.phone investigator.phone
end
end

data_contact = plan.contributors.data_curation.first || plan.owner
json.data_contact do
data_contact = plan.contributors.data_curation.first
json.name data_contact.name
json.name data_contact.is_a?(Contributor) ? data_contact.name : data_contact.name(false)
json.email data_contact.email
json.phone data_contact.phone
json.phone data_contact.phone if data_contact.is_a?(Contributor)
end
json.users plan.roles.each do |role|
json.email role.user.email
Expand Down