plan/edit: produce less queries#2861
Merged
briri merged 5 commits intoDMPRoadmap:developmentfrom Apr 18, 2021
nicolasfranck:pr_plan_edit_less_queries
Merged
plan/edit: produce less queries#2861briri merged 5 commits intoDMPRoadmap:developmentfrom nicolasfranck:pr_plan_edit_less_queries
briri merged 5 commits intoDMPRoadmap:developmentfrom
nicolasfranck:pr_plan_edit_less_queries
Conversation
briri
approved these changes
Apr 18, 2021
Contributor
briri
left a comment
briri
left a comment
There was a problem hiding this comment.
thanks for this refactor @nicolasfranck
| def edit | ||
| plan = Plan.includes({ template: { phases: { sections: :questions } } }, { answers: :notes }) | ||
| plan = Plan.includes( | ||
| { template: { |
Contributor
There was a problem hiding this comment.
thanks for formatting this, it's much easier to read this way
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
…ss_queries plan/edit: produce less queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
question_format question_options annotations themesto list ofincludeinPlansControllerincludeinSection#answered_questions, because already done byPlansControllerand because it breaks the chain of relationswhereandorderbyselectandsortin modelQuestionbecause it reexecutes the queries instead of using the relationsGuidancePresenter#guidance_groups_by_themeConditionsHelperYou should see less queries in the log when opening the tab "Write plan"
P.S. Is
ConditionsHelper#num_section_questionsstill expected to receivesectionandphaseas hashes, or is this kept for backward compatibility for those who are branding their views?