Merged
Conversation
…eploy/dmponline
Pull latest from DMProadmap
briri
approved these changes
Mar 30, 2021
Contributor
briri
left a comment
briri
left a comment
There was a problem hiding this comment.
looks good @raycarrick. Just some minor Rubocop cleanup. Feel free to merge once its happy.
| @crosswalk.map { |rec| rec[:name] }.to_json | ||
| begin | ||
| @crosswalk.map { |rec| rec[:name] }.to_json | ||
| rescue |
Contributor
There was a problem hiding this comment.
No need for the begin here and RuboCop prefers specifying an error type. Use:
def select_list
@crosswalk.map { |rec| rec[:name] }.to_json
rescue StandardError => e
nil
endModify form of rescue. No functional change.
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
Org selection options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce switch in config (in _dmproadmap.rb) which uses the local_only partial for org selection and doesn't allow on the fly account creation.