users table not sorting on department or org

[raycarrick-ed]

Fixes #2785.

Changes proposed in this PR:

• if sorting on a related model (e.g. dept or org) need to form the scope differently to include the related table

[briri]

That's really strange. I can confirm its failing in DMPTool as well.

The sort works though for other tables like the Admin -> Plans one:

<th scope="col"><%= _('Project Title') %>&nbsp;<%= paginable_sort_link('plans.title') %></th>
<th scope="col"><%= _('Template') %>&nbsp;<%= paginable_sort_link('templates.title') %></th>
<th scope="col"><%= _('Organisation') %>&nbsp;<%= paginable_sort_link('orgs.name') %></th>

It looks like the Users view uses the same paginable_sort_link. Perhaps the issue lies in the users.rb model or the controllers/paginable/users_controller.rb

[briri]

Ah I see, its an issue with table name orgs vs active model's association name org.

[briri]

I ran this locally and everything seemed to be working properly. I verified that a few of the other paginable views are still working.

It looks like you just have a few Rubocop issues to clean up then feel free to merge.