fix section sort#2735
Merged
briri merged 5 commits intoDMPRoadmap:developmentfrom Nov 25, 2020
nicolasfranck:fix_section_sort
Merged
fix section sort#2735briri merged 5 commits intoDMPRoadmap:developmentfrom nicolasfranck:fix_section_sort
briri merged 5 commits intoDMPRoadmap:developmentfrom
nicolasfranck:fix_section_sort
Conversation
briri
requested changes
Nov 19, 2020
Contributor
briri
left a comment
briri
left a comment
There was a problem hiding this comment.
looks good @nicolasfranck. Just make that one small change and we will be good 👍
| method: 'post', | ||
| data: { sort_order: sectionIds }, | ||
| type: 'post', | ||
| $.param({ 'phase[sort_order]': sectionIds }), |
Contributor
There was a problem hiding this comment.
I think you're missing data: here. I receive a JS error with the above
Contributor
Author
|
Fixed. Btw, how did you manage to merge in your development branch into my branch? See 11d9592 |
Contributor
|
sorry about that! GitHub has a 'Update branch' button that shows up when the branch being PRed isn't up to date. Its a bit dangerous I guess since it updates a repo I am not a member of! |
Contributor
|
I'm additionally updating this branch, see #2741 (comment) for an explanation |
briri
approved these changes
Nov 25, 2020
|
Assuming that this is about dragging template sections around, that is working for me. |
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
fix section sort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it tries to fix: if you, in the org-admin, try to move the section headers, you'll get a javascript in the console.
Fix:
$.rails.ajaxshould use optiontype, notmethodOrgAdmin::PhasesController#sortexpectsphase[sort_order], not justsort_order