Skip to content

Minor patch for Admin not being able to remove an Org's Shib entityID#2728

Merged
xsrust merged 5 commits intomasterfrom
shib-entity-id-fix
Nov 23, 2020
Merged

Minor patch for Admin not being able to remove an Org's Shib entityID#2728
xsrust merged 5 commits intomasterfrom
shib-entity-id-fix

Conversation

@briri
Copy link
Contributor

@briri briri commented Nov 17, 2020

Fixes #2288.

Changes proposed in this PR:

  • Add logic that removes the shibboleth entityID identifier when the user blanks out the field in the UI

@briri briri changed the title fix issue with admin not being able to remove the Shib entityID fix issue with GitHub Actions and minor patch for Admin not being able to remove an Org's Shib entityID Nov 17, 2020
@briri briri changed the title fix issue with GitHub Actions and minor patch for Admin not being able to remove an Org's Shib entityID Minor patch for Admin not being able to remove an Org's Shib entityID Nov 19, 2020
@xsrust xsrust merged commit b49d746 into master Nov 23, 2020
@briri briri deleted the shib-entity-id-fix branch December 18, 2020 17:00
portagenetwork pushed a commit to portagenetwork/roadmap that referenced this pull request Feb 24, 2022
…DMPRoadmap#2728)

* fix issue with admin not being able to remove the Shib entityID

* fix for github action env variables

* fix for github action env variables

* fix for github action env variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes to an Organization's Shibboleth identifier does not save

2 participants