Create Account: Fix styling/code issues for Organisation dropdown

[briri]

• Use the auto-complete box (see views/plans/new.html.erb for an example) for the org dropdown list
• Update styling (add left-indent class, etc.)
• Make sure JS is still working to hide/show the other org box
• Make sure that org selection is saved properly

[kmcgre]

@sjDCC @stephaniesimms
org_id and other_organisation now being saved to database. There's no text box for other_organisation in the edit personal details page for the user so I'll add that.

What should happen if a user selects an organisation from the dropdown, clicks the link to show the other org box and enters an "other organisation"?

[sjDCC]

Thanks @kmcgre Definitely good to list the other org value in a field under edit profile

I guess your second question is about the account creation process? If so, one should overrule / clear the value for the other as people can only either a) select an org from the list or b) enter an 'other org' value. They can't have an entry for each.

Just checked on DMPonline live site and this is how it works. If I select an org from the list (screengrab 1) and then click the link for "My organisation isn't listed" the dropdown value clears and is changed to 'Other' and a box appears for entering the value (screengrab 2). The same works vice versa too.

[vyruss]

@sjDCC so we would want that behaviour on the Edit profile page too, correct?

[sjDCC]

Yes, definitely. We only ever want them to have one value - an org from the dropdown list, or a text entry for 'other org'. @kmcgre if this is related to the addition of the field under 'edit profile' you can maybe just replicate the logic/code from the 'create account' process as it should work in the same way

[stephaniesimms]

I'm not clear about the expected behavior - after testing here are some notes:

• I was just able to create an account without selecting an Org. I left the field blank and was not forced to select "Other" nor did I receive an error msg. When I navigate to the Edit Profile page the box for Org is blank (screenshot below)
• When I click "My organisation isn't listed" on the Create Account page and under the Edit Profile page nothing happens. Should it autopopulate the box w/"Other" when a user clicks this link @sjDCC ?
• the only way to successfully save my profile is to type "Other" into the box after following the error prompt
• We should also be careful if we implement autosave throughout the site (auto-saving functionality. DMPRoadmap/roadmap#438 #450) that we make exceptions for things like this that require validation

[sjDCC]

OK, I think we definitely want to make the org mandatory. Ideally this would be implemented as we have it in DMPonline. Selecting 'My org is not listed' autopopulates the box with 'other' and a text box appears to enter the name. This text box also appears when you enter 'other' yourself in the dropdown list.

Agree we should be careful with autosave. It's definitely not useful on these kind of actions.

[briri]

JS on this doesn't appear to be working. No other org box is displayed when you click the link. The same also applies to the edit profile page