Branded views not used in rails daemon mode

[nicolasfranck]

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

3.0.1

Expected behaviour:

When you startup rails in daemon mode,
the application should use the branded views:

bin/rails server -d

Actual behaviour:

In rails daemon mode, the branded views are discarded.

Steps to reproduce:

bin/rails server -d

However, if you start the application like this,

puma -d

then the branded views are used again.

[briri]

Weird! I am able to reproduce this as well.

The code that tells the Rails engine to look in the branded folder first is in the base ApplicationController.rb,

roadmap/app/controllers/application_controller.rb

Line 147 in aa01147

prepend_view_path "app/views/branded"

.

I did some debugging and can see that when running in Daemon mode it loses the context of Rails.root for some reason:

# NON-DAEMONIZED (When running as `rails s`)
# -------------------------------------------------------
@paths=[
  "/Users/me/Documents/workspace/dmptool/app/views/branded", 
  "/Users/me/Documents/workspace/dmptool/app/views", 
  "/Users/me/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/kaminari-core-1.2.1/app/views", 
  "/Users/me/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/contact_us-1.2.0/app/views", 
  "/Users/me/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/devise_invitable-2.0.3/app/views", 
  "/Users/me/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/devise-4.7.3/app/views"
]

# DAEMONIZED (when running as `rails s -d`)
# -------------------------------------------------------
@paths= [
  "/app/views/branded",
  "/Users/me/Documents/workspace/dmptool/app/views", 
  "/Users/me/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/kaminari-core-1.2.1/app/views", 
  "/Users/me/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/contact_us-1.2.0/app/views", 
  "/Users/me/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/devise_invitable-2.0.3/app/views", 
  "/Users/me/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/devise-4.7.3/app/views"
]

I'm guessing its related to this change to ActionView::PathSet but am not sure.

Updating the line in ApplicationController.rb to prepend_view_path Rails.root.join("app", "views", "branded") fixes the issue. I will submit a PR for this.