Skip to content

orgs_controller#shibboleth_ds: redirect should return #2684

@nicolasfranck

Description

@nicolasfranck

Please complete the following fields as applicable:

Expected behaviour:

Actual behaviour:

Rails complains that rendering happens twice.

Reason: https://github.com/DMPRoadmap/roadmap/blob/master/app/controllers/orgs_controller.rb#L88

The redirect does not issue a return from the function shibboleth_ds and therefore
https://github.com/DMPRoadmap/roadmap/blob/master/app/controllers/orgs_controller.rb#L96 is executed also.

Steps to reproduce:

  • checkout version 2.2.0
  • login
  • make sure there are no organisations with a shibboleth scheme identifier
  • go to /orgs/shibboleth

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions