Skip to content

Switch to a new i18n library#275

Merged
greboid merged 1 commit intoDMDirc:masterfrom
csmith:master
Mar 18, 2019
Merged

Switch to a new i18n library#275
greboid merged 1 commit intoDMDirc:masterfrom
csmith:master

Conversation

@csmith
Copy link
Member

@csmith csmith commented Mar 18, 2019

This fixes issues with translations with quotes etc that need to be
escaped, and deals with multi-line strings.

Closes #227

This fixes issues with translations with quotes etc that need to be
escaped, and deals with multi-line strings.

Closes DMDirc#227
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #275 into master will decrease coverage by 0.07%.
The diff coverage is 7.69%.

@@             Coverage Diff             @@
##             master    #275      +/-   ##
===========================================
- Coverage     30.87%   30.8%   -0.08%     
  Complexity       48      48              
===========================================
  Files            22      22              
  Lines          1234    1237       +3     
  Branches        228     229       +1     
===========================================
  Hits            381     381              
- Misses          816     819       +3     
  Partials         37      37
Impacted Files Coverage Δ Complexity Δ
src/main/kotlin/com/dmdirc/ServerlistDialog.kt 36.54% <ø> (ø) 0 <0> (ø) ⬇️
src/main/kotlin/com/dmdirc/IrcEventMapper.kt 66.66% <ø> (ø) 36 <0> (ø) ⬇️
src/main/kotlin/com/dmdirc/MainView.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
src/main/kotlin/com/dmdirc/SettingsDialog.kt 23.72% <ø> (ø) 0 <0> (ø) ⬇️
src/main/kotlin/com/dmdirc/WindowUI.kt 22.38% <0%> (ø) 0 <0> (ø) ⬇️
src/main/kotlin/com/dmdirc/Translations.kt 8.33% <0%> (-2.78%) 0 <0> (ø)
src/main/kotlin/com/dmdirc/JoinDialog.kt 30.43% <0%> (ø) 0 <0> (ø) ⬇️
src/main/kotlin/com/dmdirc/Config.kt 82.45% <100%> (ø) 0 <0> (ø) ⬇️

@greboid greboid merged commit 3cecf57 into DMDirc:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"To get started..." text not translated

2 participants