Add support for range verfication #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Oct 3, 2019
hashchain.c
Outdated
| @@ -64,24 +65,37 @@ struct hash_chain hash_chain_create(void *base, | |||
| * @param h Pointer to a hash. | |||
| * @param tip Pointer to the "tip" hash. | |||
| * @param hash Hash algorithm to use. | |||
| * @param True if hash(h) == tip | |||
| * @param trange Maximum test size. | |||
There was a problem hiding this comment.
I think the semantics of this function is "Could the function be verified in the given range?".
|
Please update |
jserv
reviewed
Oct 3, 2019
hashchain.c
Outdated
| @@ -161,11 +175,12 @@ int cmd_verify(int argc, char **argv) | |||
| { | |||
| if (argc < 4) { | |||
| fprintf(stderr, "error: too few args\n"); | |||
| fprintf(stderr, "usage: %s ALGO QUERY ANCHOR\n", argv[0]); | |||
| fprintf(stderr, "usage: %s ALGO QUERY ANCHOR [MAX_TRANGE]\n", argv[0]); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
trangeparameter tohash_chain_verifyto specify the maximum range.The default test range is specified in
DEFAULT_TRANGE.