Skip to content

Conversation

@cdboer
Copy link
Collaborator

@cdboer cdboer commented Jun 4, 2021

Fixes #47 .

Changes proposed in this pull request:

  • Remove resource type from attribute keys that has been prepended to each key name.
  • Reformat meta.py using the black formatter

@cdboer cdboer added this to the 0.5 milestone Jun 4, 2021
@cdboer cdboer self-assigned this Jun 4, 2021
@cdboer
Copy link
Collaborator Author

cdboer commented Jun 4, 2021

@onyame This pull request will fix #47. Note that as the attribute names of nearly all attributes are going to change as a result of this PR, CYHPER queries that have been crafted using previous versions of GitLab2PROV will possibly no longer work.

If that does not pose an issue for you, i would go on to merge and therefore complete the milestone for v0.5 . I'll wait for your feedback.

@onyame onyame merged commit adc8260 into master Jun 8, 2021
@cdboer cdboer deleted the remove-resource-type-from-attribute-keys branch June 9, 2021 11:18
@onyame onyame added the model Improvements or additions to the PROV model label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model Improvements or additions to the PROV model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove resource names from attributes keys

3 participants