Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] env argument in HerReplayBuffer.sample is not None by default #788

Closed
qgallouedec opened this issue Feb 24, 2022 · 1 comment · Fixed by #790
Closed

[Bug] env argument in HerReplayBuffer.sample is not None by default #788

qgallouedec opened this issue Feb 24, 2022 · 1 comment · Fixed by #790
Labels
bug Something isn't working

Comments

@qgallouedec
Copy link
Collaborator

Hi,

It looks like the env argument of the method sample of HerReplayBuffer is not None by default.

stable-baselines3/stable_baselines3/her/her_replay_buffer.py

Line 198 in 13fcb12

env: Optional[VecNormalize],

To be consistent with other replay buffer, I suggest the following modification:

 env: Optional[VecNormalize] = None,
@qgallouedec qgallouedec added the bug Something isn't working label Feb 24, 2022
@Miffyli
Copy link
Collaborator

Miffyli commented Feb 24, 2022

Thanks for spotting this and taking your time to report it!
And yup, indeed it should default to None. A PR would be very much welcomed :)

qgallouedec added a commit to qgallouedec/stable-baselines3 that referenced this issue Feb 24, 2022
@qgallouedec
env to None by default in HerReplayBuffer.sample (DLR-RM#788)
0caae57
@qgallouedec qgallouedec mentioned this issue Feb 24, 2022
Merged
14 tasks
araffin added a commit that referenced this issue Feb 24, 2022
@qgallouedec @araffin
None as default value for env in HerReplayBuffer.sample + DQN…
db5366f 
… batch size typing fix (#790)

* `env` to `None` by default in `HerReplayBuffer.sample` (#788)

* Fix DQN batch_size typing

* Fix changelog

Co-authored-by: Antonin RAFFIN <antonin.raffin@ensta.org>
Co-authored-by: Antonin Raffin <antonin.raffin@dlr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@Miffyli @qgallouedec