Skip to content

Conversation

@PilaScat
Copy link
Contributor

@PilaScat PilaScat commented Jun 6, 2025

Already tested, working as expected, if you like to test you could try my repo
I have a big party coming 28th june, I needed to make it perfect ahah
If you want you could use that image for the integration on HA, maybe I could update even that, but first there is a major problem to be fixed in #27

@PilaScat
Copy link
Contributor Author

https://github.com/user-attachments/assets/512234c8-a482-4287-acdb-304430802ce7
This is a preview if you don't have time to try it yourself

@PilaScat
Copy link
Contributor Author

PilaScat commented Jun 14, 2025

Okay we are are ready to merge, but there is something not working, before it was
The songs are added to queue but they are not being played automatically, and when autostart is enabled the queue is broken, tomorrow I'll test more

@PilaScat
Copy link
Contributor Author

Tried again after your commit df96307 and now all works right away
Cleaned up readme, added some updated photos and videos, hopefully ready to merge now

- Media Player: Select your Music Assistant media player
- Default Playlist: Enter the name of your fallback playlist

## Contributing
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.md already present


Feel free to contribute! Open an issue or submit a PR.

## Credits
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already present in the sidebar, better to leave them there so you don't have to update the readme every time

"music_assistant"
],
"codeowners": ["@DJS91", "@TheOddPirate"],
"codeowners": ["@DJS91", "@TheOddPirate", "@PilaScat"],
Copy link
Contributor Author

@PilaScat PilaScat Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is your choice, but I think I spent enough time to be nominated

@PilaScat
Copy link
Contributor Author

I don't know how to do the favicon, I tried to use your logo but it's too complex for such a small icon
image
I would leave the one I added

PilaScat and others added 2 commits June 16, 2025 18:59
I want to keep the code owners limited I'll add this to the Credits section.
@DJS91 DJS91 merged commit c6503b0 into DJS91:main Jun 18, 2025
@PilaScat
Copy link
Contributor Author

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants