Skip to content

[8.0] fix: SSHCE.getPilotOutput()#7025

Merged
fstagni merged 1 commit intoDIRACGrid:rel-v8r0from
aldbr:rel-v8r0_FIX_SSHCEConnection
May 22, 2023
Merged

[8.0] fix: SSHCE.getPilotOutput()#7025
fstagni merged 1 commit intoDIRACGrid:rel-v8r0from
aldbr:rel-v8r0_FIX_SSHCEConnection

Conversation

@aldbr
Copy link
Contributor

@aldbr aldbr commented May 19, 2023

A minor fix that should allow us to get pilot outputs from SSHCE.
I remove the pilot stamp from the jobID if present.

I also realized that _ssh_call() was not working perfectly.

There exist a few popular python libraries to perform SSH operations like Fabric (Paramiko) (https://docs.fabfile.org/en/stable/). Wouldn't it be more reliable that our _ssh_call() method?

BEGINRELEASENOTES
*Resources
FIX: SSHCE getPilotOutput remove stamp
ENDRELEASENOTES

@aldbr aldbr requested review from atsareg and fstagni as code owners May 19, 2023 09:31
@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label May 19, 2023
@fstagni
Copy link
Contributor

fstagni commented May 19, 2023

There exist a few popular python libraries to perform SSH operations like Fabric (Paramiko) (https://docs.fabfile.org/en/stable/). Wouldn't it be more reliable that our _ssh_call() method?

Probably... but this looks like a task that you might want to look into later on.

@fstagni fstagni merged commit fe7d0d9 into DIRACGrid:rel-v8r0 May 22, 2023
@DIRACGridBot DIRACGridBot added the sweep:done All sweeping actions have been done for this PR label May 22, 2023
DIRACGridBot pushed a commit to DIRACGridBot/DIRAC that referenced this pull request May 22, 2023
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/5043736310

Successful:

  • integration

fstagni pushed a commit to fstagni/DIRAC that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants