[8.0] fix: SSHCE.getPilotOutput()#7025
Merged
fstagni merged 1 commit intoDIRACGrid:rel-v8r0from May 22, 2023
Merged
Conversation
Contributor
Probably... but this looks like a task that you might want to look into later on. |
fstagni
approved these changes
May 22, 2023
DIRACGridBot
pushed a commit
to DIRACGridBot/DIRAC
that referenced
this pull request
May 22, 2023
|
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/5043736310 Successful:
|
fstagni
pushed a commit
to fstagni/DIRAC
that referenced
this pull request
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor fix that should allow us to get pilot outputs from
SSHCE.I remove the pilot stamp from the jobID if present.
I also realized that
_ssh_call()was not working perfectly.Connection refusedfor instance (I did not change that).There exist a few popular python libraries to perform SSH operations like
Fabric (Paramiko)(https://docs.fabfile.org/en/stable/). Wouldn't it be more reliable that our_ssh_call()method?BEGINRELEASENOTES
*Resources
FIX: SSHCE getPilotOutput remove stamp
ENDRELEASENOTES