-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8] fail when command documentation does not build, fix for importlib_metadata v5 #6458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
Cherry pick this PR to integration after merge
label
Oct 27, 2022
andresailer
force-pushed
the
v8_failDoc
branch
from
October 27, 2022 07:37
163d5ce
to
c6b2591
Compare
Is an updated version of importlib_metadata |
Hmm, maybe fixed it (following python/importlib_metadata#409) |
andresailer
changed the title
[v8] fail when command documentation does not build
[v8] fail when command documentation does not build, fix for importlib_metadata v5
Oct 27, 2022
chrisburr
approved these changes
Oct 27, 2022
DIRACGridBot
added
the
sweep:done
All sweeping actions have been done for this PR
label
Oct 27, 2022
DIRACGridBot
pushed a commit
to DIRACGridBot/DIRAC
that referenced
this pull request
Oct 27, 2022
… fix for importlib_metadata v5
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/3336490885 Successful:
|
chrisburr
added a commit
to DIRACGrid/DIRACOS2
that referenced
this pull request
Oct 28, 2022
simon-mazenoux
pushed a commit
to simon-mazenoux/DIRAC
that referenced
this pull request
May 24, 2023
… fix for importlib_metadata v5
simon-mazenoux
pushed a commit
to simon-mazenoux/DIRAC
that referenced
this pull request
May 24, 2023
… fix for importlib_metadata v5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alsoTargeting:integration
Cherry pick this PR to integration after merge
sweep:done
All sweeping actions have been done for this PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the output for the commands is now just "oops..." Not sure where this comes from :/
BEGINRELEASENOTES
*Core
FIX: Scripts: adapt to proper way of getting console_scripts entry_points, mandatory for importlib_metadata v5
*Docs
FIX: Fail if one the commands cannot be documented
ENDRELEASENOTES