Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8] fail when command documentation does not build, fix for importlib_metadata v5 #6458

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

andresailer
Copy link
Contributor

@andresailer andresailer commented Oct 27, 2022

For some reason the output for the commands is now just "oops..." Not sure where this comes from :/

  diracdoctools.Utilities:    ERROR: Error when runnning command python /home/docs/checkouts/readthedocs.org/user_builds/dirac/checkouts/rel-v8r0/src/DIRAC/ConfigurationSystem/scripts/dirac_admin_check_config_options.py -h: 'Traceback (most recent call last):\n  File "/home/docs/checkouts/readthedocs.org/user_builds/dirac/conda/rel-v8r0/lib/python3.9/site-packages/importlib_metadata/__init__.py", line 287, in __getitem__\n    return next(iter(self.select(name=name)))\nStopIteration\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n  File "/home/docs/checkouts/readthedocs.org/user_builds/dirac/checkouts/rel-v8r0/src/DIRAC/ConfigurationSystem/scripts/dirac_admin_check_config_options.py", line 214, in <module>\n    main()\n  File "/home/docs/checkouts/readthedocs.org/user_builds/dirac/checkouts/rel-v8r0/src/DIRAC/Core/Base/Script.py", line 54, in __call__\n    matches = [ep for ep in metadata.entry_points()["console_scripts"] if ep.name == self.scriptName]\n  File "/home/docs/checkouts/readthedocs.org/user_builds/dirac/conda/rel-v8r0/lib/python3.9/site-packages/importlib_metadata/__init__.py", line 289, in __getitem__\n    raise KeyError(name)\nKeyError: \'console_scripts\'\n'
         CommandReference:  WARNING: NO DOC for dirac-admin-check-config-options

BEGINRELEASENOTES

*Core
FIX: Scripts: adapt to proper way of getting console_scripts entry_points, mandatory for importlib_metadata v5

*Docs
FIX: Fail if one the commands cannot be documented

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Oct 27, 2022
@andresailer
Copy link
Contributor Author

Is an updated version of importlib_metadata
+ importlib_metadata 5.0.0 hd8ed1ab_1 conda-forge/noarch 8 KB
@chrisburr can we fix to version 4 series?

@andresailer
Copy link
Contributor Author

Hmm, maybe fixed it (following python/importlib_metadata#409)

@andresailer andresailer marked this pull request as ready for review October 27, 2022 08:00
@andresailer andresailer changed the title [v8] fail when command documentation does not build [v8] fail when command documentation does not build, fix for importlib_metadata v5 Oct 27, 2022
@fstagni fstagni merged commit 68f83dd into DIRACGrid:rel-v8r0 Oct 27, 2022
@DIRACGridBot DIRACGridBot added the sweep:done All sweeping actions have been done for this PR label Oct 27, 2022
DIRACGridBot pushed a commit to DIRACGridBot/DIRAC that referenced this pull request Oct 27, 2022
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/3336490885

Successful:

  • integration

chrisburr added a commit to DIRACGrid/DIRACOS2 that referenced this pull request Oct 28, 2022
@andresailer andresailer deleted the v8_failDoc branch October 28, 2022 13:58
simon-mazenoux pushed a commit to simon-mazenoux/DIRAC that referenced this pull request May 24, 2023
simon-mazenoux pushed a commit to simon-mazenoux/DIRAC that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants