Merge pull request crabbly#257 from tvdeyen/fix-chrome-detection

Fix chrome detection
DIMASIK1502 · Nov 21, 2018 · d88b8e4 · d88b8e4
2 parents a50a41d + 269efa6
commit d88b8e4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/js/browser.js b/src/js/browser.js
@@ -12,8 +12,8 @@ const Browser = {
     return !Browser.isIE() && !!window.StyleMedia
   },
   // Chrome 1+
-  isChrome: () => {
-    return !!window.chrome && !!window.chrome.webstore
+  isChrome: (context = window) => {
+    return !!context.chrome
   },
   // At least Safari 3+: "[object HTMLElementConstructor]"
   isSafari: () => {

diff --git a/test/unit/browser.spec.js b/test/unit/browser.spec.js
@@ -21,6 +21,18 @@ describe('Browser', () => {
     expect(typeof Browser.isChrome()).toBe('boolean')
   })
 
+  describe('isChrome()', () => {
+    it('returns true for Google Chrome', () => {
+      const stubbedWindow = { chrome: {} }
+      expect(Browser.isChrome(stubbedWindow)).toBeTruthy()
+    })
+
+    it('returns false for non Google Chrome', () => {
+      const stubbedWindow = {}
+      expect(Browser.isChrome(stubbedWindow)).toBeFalsy()
+    })
+  })
+
   it('has a function named isSafari that returns a boolean value', () => {
     expect(typeof Browser.isSafari).toBe('function')
     expect(typeof Browser.isSafari()).toBe('boolean')