-
Notifications
You must be signed in to change notification settings - Fork 0
[Refactor] 2차 QA 디자인 수정 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
14c8bec
ea38e0f
768878c
8c653fa
46ee33d
9126e0e
cef896f
3424c4f
28b2f52
e95d955
1661baa
191297d
b5754b6
eed0fa3
724985c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| <resources> | ||
| <string name="app_name">DPlay</string> | ||
| <string name="app_name">Dplay</string> | ||
| <string name="notification_title">디플레이</string> | ||
| <string name="notification_content">오늘의 질문이 도착했어요</string> | ||
| </resources> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| package com.example.designsystem.component | ||
|
|
||
| import androidx.compose.foundation.Image | ||
| import androidx.compose.foundation.layout.Column | ||
| import androidx.compose.foundation.layout.Spacer | ||
| import androidx.compose.foundation.layout.fillMaxSize | ||
| import androidx.compose.foundation.layout.height | ||
| import androidx.compose.foundation.layout.size | ||
| import androidx.compose.material3.Text | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.Alignment | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.res.painterResource | ||
| import androidx.compose.ui.res.stringResource | ||
| import androidx.compose.ui.tooling.preview.Preview | ||
| import androidx.compose.ui.unit.dp | ||
| import com.dplay.designsystem.R | ||
| import com.example.designsystem.theme.DPlayTheme | ||
|
|
||
| @Composable | ||
| fun DPlayErrorScreen( | ||
| modifier: Modifier = Modifier, | ||
| onBackIconClick: () -> Unit = {}, | ||
| ) { | ||
| Column( | ||
| modifier = modifier.fillMaxSize(), | ||
| horizontalAlignment = Alignment.CenterHorizontally, | ||
| ) { | ||
| DplayLeftIconTopAppBar { | ||
| onBackIconClick() | ||
| } | ||
|
|
||
| Spacer(modifier = Modifier.height(height = 132.dp)) | ||
|
|
||
| Image( | ||
| painter = painterResource(id = R.drawable.img_warning), | ||
| contentDescription = null, | ||
| modifier = Modifier.size(size = 140.dp), | ||
| ) | ||
|
|
||
| Spacer(modifier = Modifier.height(height = 12.dp)) | ||
|
|
||
| Text( | ||
| text = stringResource(R.string.error_main_text), | ||
| style = DPlayTheme.typography.bodyBold16, | ||
| color = DPlayTheme.colors.dplayBlack, | ||
| ) | ||
|
|
||
| Spacer(modifier = Modifier.height(height = 8.dp)) | ||
|
|
||
| Text( | ||
| text = stringResource(R.string.error_sub_text), | ||
| style = DPlayTheme.typography.bodyMed14, | ||
| color = DPlayTheme.colors.gray400, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| @Preview | ||
| @Composable | ||
| private fun DPlayErrorScreenPreview(modifier: Modifier = Modifier) { | ||
| DPlayTheme { | ||
| DPlayErrorScreen(modifier = modifier) | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package com.example.designsystem.component | ||
|
|
||
| import androidx.compose.foundation.layout.Box | ||
| import androidx.compose.foundation.layout.fillMaxSize | ||
| import androidx.compose.material3.CircularProgressIndicator | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.Alignment | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.tooling.preview.Preview | ||
| import com.example.designsystem.theme.DPlayTheme | ||
|
|
||
| @Composable | ||
| fun DPlayLoadingScreen( | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| Box( | ||
| modifier = modifier.fillMaxSize(), | ||
| contentAlignment = Alignment.Center, | ||
| ) { | ||
| CircularProgressIndicator() | ||
|
||
| } | ||
| } | ||
|
|
||
| @Preview | ||
| @Composable | ||
| private fun DPlayLoadingScreenPreview() { | ||
| DPlayTheme { | ||
| DPlayLoadingScreen() | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,8 +9,10 @@ import androidx.compose.material3.Text | |
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.Alignment | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.text.TextStyle | ||
| import androidx.compose.ui.text.style.TextOverflow | ||
| import androidx.compose.ui.tooling.preview.Preview | ||
| import androidx.compose.ui.unit.Dp | ||
| import androidx.compose.ui.unit.dp | ||
| import com.example.designsystem.theme.DPlayTheme | ||
| import com.example.designsystem.util.noRippleClickable | ||
|
|
@@ -22,6 +24,10 @@ fun DPlayMusicGridItem( | |
| musicArtistName: String, | ||
| modifier: Modifier = Modifier, | ||
| onClick: () -> Unit = {}, | ||
| titleStyle: TextStyle = DPlayTheme.typography.bodySemi14, | ||
| artistStyle: TextStyle = DPlayTheme.typography.capMed12, | ||
| spaceBetweenCover: Dp = 5.dp, | ||
| spaceBetweenText: Dp = 1.dp, | ||
| ) { | ||
| Column(modifier = modifier.noRippleClickable(onClick = onClick), horizontalAlignment = Alignment.CenterHorizontally) { | ||
| DPlayMusicDiscItem( | ||
|
|
@@ -30,18 +36,18 @@ fun DPlayMusicGridItem( | |
| Modifier | ||
| .fillMaxWidth(), | ||
| ) | ||
| Spacer(modifier = Modifier.height(5.dp)) | ||
| Spacer(modifier = Modifier.height(spaceBetweenCover)) | ||
| Text( | ||
| text = musicName, | ||
| style = DPlayTheme.typography.bodySemi14, | ||
| style = titleStyle, | ||
| color = DPlayTheme.colors.dplayBlack, | ||
| maxLines = 1, | ||
| overflow = TextOverflow.Ellipsis, | ||
| ) | ||
| Spacer(modifier = Modifier.height(1.dp)) | ||
| Spacer(modifier = Modifier.height(spaceBetweenText)) | ||
| Text( | ||
| text = musicArtistName, | ||
| style = DPlayTheme.typography.capMed12, | ||
| style = artistStyle, | ||
|
Comment on lines
27
to
50
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 해당 스타일과 space값 인자로 주입받도록 수정하신 이유가 있나요??
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 컴포넌트의 타입이 2개 더라고요.. |
||
| color = DPlayTheme.colors.gray400, | ||
| maxLines = 1, | ||
| overflow = TextOverflow.Ellipsis, | ||
|
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.example.domain.model | ||
|
|
||
| enum class LoadingState { | ||
| LOADING, | ||
| SUCCESS, | ||
| FAILURE | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DPlayErrorScreen의 Column에 verticalArrangement가 설정되지 않았습니다. 현재 구조에서는 상단에 요소들이 밀집되어 있는데, Arrangement.Top을 명시적으로 설정하거나 다른 정렬 방식을 고려해보세요. 또한, 에러 컨텐츠가 화면 중앙에 위치하도록 Box를 사용하거나 weight를 활용하는 것이 더 나은 UX를 제공할 수 있습니다.