Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified app/src/main/ic_launcher-playstore.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions app/src/main/java/com/dplay/worker/DailyQuestionWorker.kt
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ class DailyQuestionWorker(
private fun showNotification() {
val notificationManager =
context.getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
val title = context.getString(R.string.notification_title)
val content = context.getString(R.string.notification_content)

// 명시적으로 버전 관리
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
Expand Down Expand Up @@ -55,8 +57,8 @@ class DailyQuestionWorker(
NotificationCompat
.Builder(context, CHANNEL_ID)
.setSmallIcon(R.mipmap.ic_launcher)
.setContentTitle(NOTIFICATION_CONTENT_TITLE)
.setContentText(NOTIFICATION_CONTENT_TEXT)
.setContentTitle(title)
.setContentText(content)
.setPriority(NotificationCompat.PRIORITY_DEFAULT)
.setContentIntent(pendingIntent)
.setAutoCancel(true)
Expand All @@ -70,8 +72,6 @@ class DailyQuestionWorker(
const val CHANNEL_NAME = "Daily Question"
const val CHANNEL_DESCRIPTION = "Daily Question Notification"
const val NOTIFICATION_ID = 1001
const val NOTIFICATION_CONTENT_TITLE = "오늘의 질문이 도착했습니다!"
const val NOTIFICATION_CONTENT_TEXT = "지금 바로 확인해보세요."
const val WORK_NAME = "daily_question_work"
const val TAG = "DailyQuestionWorker"
}
Expand Down
Binary file modified app/src/main/res/mipmap-hdpi/ic_launcher.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-hdpi/ic_launcher_foreground.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-hdpi/ic_launcher_round.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-mdpi/ic_launcher.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-mdpi/ic_launcher_foreground.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-mdpi/ic_launcher_round.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-xhdpi/ic_launcher.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-xhdpi/ic_launcher_foreground.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-xhdpi/ic_launcher_round.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-xxhdpi/ic_launcher.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-xxhdpi/ic_launcher_foreground.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-xxhdpi/ic_launcher_round.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-xxxhdpi/ic_launcher.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-xxxhdpi/ic_launcher_foreground.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.webp
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<resources>
<string name="app_name">DPlay</string>
<string name="app_name">Dplay</string>
<string name="notification_title">디플레이</string>
<string name="notification_content">오늘의 질문이 도착했어요</string>
</resources>
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
package com.example.designsystem.component

import androidx.compose.foundation.Image
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.size
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.dplay.designsystem.R
import com.example.designsystem.theme.DPlayTheme

@Composable
fun DPlayErrorScreen(
modifier: Modifier = Modifier,
onBackIconClick: () -> Unit = {},
) {
Column(
modifier = modifier.fillMaxSize(),
horizontalAlignment = Alignment.CenterHorizontally,
) {
Comment on lines +25 to +28
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DPlayErrorScreen의 Column에 verticalArrangement가 설정되지 않았습니다. 현재 구조에서는 상단에 요소들이 밀집되어 있는데, Arrangement.Top을 명시적으로 설정하거나 다른 정렬 방식을 고려해보세요. 또한, 에러 컨텐츠가 화면 중앙에 위치하도록 Box를 사용하거나 weight를 활용하는 것이 더 나은 UX를 제공할 수 있습니다.

Copilot generated this review using guidance from repository custom instructions.
DplayLeftIconTopAppBar {
onBackIconClick()
}

Spacer(modifier = Modifier.height(height = 132.dp))

Image(
painter = painterResource(id = R.drawable.img_warning),
contentDescription = null,
modifier = Modifier.size(size = 140.dp),
)

Spacer(modifier = Modifier.height(height = 12.dp))

Text(
text = stringResource(R.string.error_main_text),
style = DPlayTheme.typography.bodyBold16,
color = DPlayTheme.colors.dplayBlack,
)

Spacer(modifier = Modifier.height(height = 8.dp))

Text(
text = stringResource(R.string.error_sub_text),
style = DPlayTheme.typography.bodyMed14,
color = DPlayTheme.colors.gray400,
)
}
}

@Preview
@Composable
private fun DPlayErrorScreenPreview(modifier: Modifier = Modifier) {
DPlayTheme {
DPlayErrorScreen(modifier = modifier)
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package com.example.designsystem.component

import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.material3.CircularProgressIndicator
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.tooling.preview.Preview
import com.example.designsystem.theme.DPlayTheme

@Composable
fun DPlayLoadingScreen(
modifier: Modifier = Modifier,
) {
Box(
modifier = modifier.fillMaxSize(),
contentAlignment = Alignment.Center,
) {
CircularProgressIndicator()
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DPlayLoadingScreen의 CircularProgressIndicator에 색상이 지정되지 않았습니다. Material3의 기본 색상을 사용하는 것이 의도된 것인지 확인이 필요합니다. 다른 컴포넌트들과 일관성을 위해 DPlayTheme.colors를 사용하여 명시적으로 색상을 지정하는 것을 고려해보세요.

예: CircularProgressIndicator(color = DPlayTheme.colors.dplayPink)

Copilot generated this review using guidance from repository custom instructions.
}
}

@Preview
@Composable
private fun DPlayLoadingScreenPreview() {
DPlayTheme {
DPlayLoadingScreen()
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.text.TextStyle
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
import com.example.designsystem.theme.DPlayTheme
import com.example.designsystem.util.noRippleClickable
Expand All @@ -22,6 +24,10 @@ fun DPlayMusicGridItem(
musicArtistName: String,
modifier: Modifier = Modifier,
onClick: () -> Unit = {},
titleStyle: TextStyle = DPlayTheme.typography.bodySemi14,
artistStyle: TextStyle = DPlayTheme.typography.capMed12,
spaceBetweenCover: Dp = 5.dp,
spaceBetweenText: Dp = 1.dp,
) {
Column(modifier = modifier.noRippleClickable(onClick = onClick), horizontalAlignment = Alignment.CenterHorizontally) {
DPlayMusicDiscItem(
Expand All @@ -30,18 +36,18 @@ fun DPlayMusicGridItem(
Modifier
.fillMaxWidth(),
)
Spacer(modifier = Modifier.height(5.dp))
Spacer(modifier = Modifier.height(spaceBetweenCover))
Text(
text = musicName,
style = DPlayTheme.typography.bodySemi14,
style = titleStyle,
color = DPlayTheme.colors.dplayBlack,
maxLines = 1,
overflow = TextOverflow.Ellipsis,
)
Spacer(modifier = Modifier.height(1.dp))
Spacer(modifier = Modifier.height(spaceBetweenText))
Text(
text = musicArtistName,
style = DPlayTheme.typography.capMed12,
style = artistStyle,
Comment on lines 27 to 50
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 스타일과 space값 인자로 주입받도록 수정하신 이유가 있나요??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 컴포넌트의 타입이 2개 더라고요..

color = DPlayTheme.colors.gray400,
maxLines = 1,
overflow = TextOverflow.Ellipsis,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ fun DPlayGuidelineButton(
)

Spacer(
modifier = Modifier.size(8.dp),
modifier = Modifier.size(4.dp),
)

Text(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ sealed class CircleButtonType {
override val contentDescription: Int = R.string.circle_plus_button_icon_default_description,
) : CircleButtonType() {
override val containerSize = 56.dp
override val backgroundColor = defaultDPlayColors.dplayBlack
override val backgroundColor = defaultDPlayColors.gray600
override val iconRes = R.drawable.ic_plus_28
override val iconSize = 28.dp
override val iconTint = defaultDPlayColors.dplayWhite
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@ import androidx.annotation.StringRes
import com.dplay.designsystem.R

enum class DPlayChipType(
@DrawableRes val iconRes: Int,
@DrawableRes val drawableRes: Int,
@StringRes val stringRes: Int,
) {
EDITOR(
iconRes = R.drawable.ic_editor_20,
drawableRes = R.drawable.editor_chip,
stringRes = R.string.chip_editor,
),
NEW(
iconRes = R.drawable.ic_new_20,
drawableRes = R.drawable.new_chip,
stringRes = R.string.chip_new,
),
BEST(
iconRes = R.drawable.ic_best_20,
drawableRes = R.drawable.best_chip,
stringRes = R.string.chip_best,
),
}
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ fun GraphicModal(
modifier =
modifier
.clip(
shape = RoundedCornerShape(16.dp),
shape = RoundedCornerShape(12.dp),
).background(
color = DPlayTheme.colors.dplayWhite,
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ fun WarningModal(
onLeftButtonClick: () -> Unit = {},
onRightButtonClick: () -> Unit = {},
) {
val warningModalShape = RoundedCornerShape(16.dp)
val warningModalShape = RoundedCornerShape(12.dp)

Box(
modifier =
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions core/designsystem/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@
<string name="snackbar_message_add_collection">보관함에 추가했어요</string>
<string name="snackbar_message_streaming_not_support">미리듣기가 제공되지 않는 곡이에요</string>
<string name="snackbar_action_message_navigate_collection">보러가기</string>


<string name="error_main_text">앗! 일시적인 오류가 발생했어요</string>
<string name="error_sub_text">잠시 후 다시 시도해주세요</string>


</resources>
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package com.example.domain.model

enum class LoadingState {
LOADING,
SUCCESS,
FAILURE
}
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@ fun CommentScreen(
Modifier
.width(132.dp)
.align(Alignment.CenterHorizontally),
titleStyle = DPlayTheme.typography.titleBold18,
artistStyle = DPlayTheme.typography.bodySemi14,
spaceBetweenCover = 12.dp,
spaceBetweenText = 6.dp,
)

Spacer(modifier = Modifier.height(16.dp))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@ package com.example.detail
import com.example.designsystem.component.snackbar.type.SnackBarType
import com.example.domain.model.BADGE
import com.example.domain.model.Like
import com.example.domain.model.LoadingState
import com.example.domain.model.Track
import com.example.domain.model.Writer
import com.example.navigation.MyPageTab
import com.example.ui.base.BaseContract

class DetailContract {
data class DetailState(
val loadingState: LoadingState = LoadingState.LOADING,
val postId: Long = 0L,
val isScrapped: Boolean = false,
val content: String = "",
Expand Down Expand Up @@ -83,6 +86,8 @@ class DetailContract {
val action: (() -> Unit)? = null,
) : DetailSideEffect

data object NavigateToMyPage : DetailSideEffect
data class NavigateToMyPage(
val initialTab: MyPageTab = MyPageTab.REGISTERED,
) : DetailSideEffect
}
}
Loading