Next #1
Merged
Next #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 24, 2024 04:37
There was a problem hiding this comment.
@Izobov в целом стоит посмотреть на файлы с расширение .js и отформатировать в соответствие со стандартами (лишние отступы, завершение строк при помощи ";")
|
|
||
| ## Installation | ||
|  |
There was a problem hiding this comment.
@Izobov смотри комментарии к интеграции с angular
src/components/Diagram.vue
Outdated
| }, | ||
| unmounted() { | ||
| this.$refs.cont.innerHTML = ""; | ||
|
|
There was a problem hiding this comment.
@Izobov не хватает деструктуризации редактора
src/components/Diagram.vue
Outdated
| props: ["data"], | ||
|
|
||
| mounted() { | ||
| new DiagramEditor(this.$refs.cont, { |
There was a problem hiding this comment.
@Izobov все хорошо, но забыли загрузить данные
index.html
Outdated
| <meta charset="UTF-8" /> | ||
| <link rel="icon" href="/favicon.ico" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>DHX :: Vue</title> |
There was a problem hiding this comment.
@Izobov можно отобразить в заголовке что-то, что связано с интеграцией
Sorokin-Oleg
approved these changes
Jun 26, 2024
added 2 commits
June 26, 2024 12:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.