Add KYC files details page with extended columns#944
Merged
TaprootFreak merged 26 commits intodevelopfrom Feb 5, 2026
Merged
Conversation
- Add new /compliance/kyc-files/details route with additional columns - Add CSV export functionality to both KYC files screens - Add details navigation button (info icon) to KYC files list - Extend KycFileListEntry interface with new fields - Calculate status (open/closed) based on amlListExpiredDate - Calculate Sitzgesellschaft based on amlAccountType
- Add isLoggedIn check before fetching data to prevent 401 errors - Add Playwright E2E test for KYC Files Details page
- Test page load with correct headers and data display - Verify date format (dd.mm.yyyy) and volume format (Swiss) - Test check and download button visibility - Test CSV export functionality - Add screenshots for visual verification
- Status filter (All/Open/Closed) - Date range filter for Eröffnungsdatum (from/to) - Check All and CSV Export now work on filtered data - Shows count of filtered entries
Remove amlListStatus fallback logic as it's not applicable for the KYC file status determination. Status is now determined solely by whether amlListExpiredDate is set (closed) or not (open).
- Move Check Filtered Files and CSV Export buttons from table header to filter bar for better UX - Change download icon from ARROW_DOWN to FILE for consistency
- Replace hardcoded address/signature with ADMIN_SEED from api/.env
- Use session token authentication matching other compliance tests
- Add proper TypeScript types for Page parameter
- Replace waitForTimeout with waitForLoadState('networkidle')
- Wrap async button handlers in try-catch blocks - Display error message to user when API calls fail
- Remove committed screenshots from e2e tests (should not be in repo) - Remove screenshot generation from E2E test code - Fix CSV export icon: use ARROW_DOWN consistently on both screens
Collaborator
Author
|
Ready for Merge |
davidleomay
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/compliance/kyc-files/detailsroute with extended columns (Status, Domizil, Sitzgesellschaft, Dates, GmeR, PEP, etc.)Test plan
/compliance/kyc-filesand verify info button appears/compliance/kyc-files/details