Gm editor changes #913
Merged
Gm editor changes #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…same base type as the container. Also simplify it a bit.
scripts/gui/gm-editor.lua
Outdated
| if ntype== nil then | ||
| dialog.showMessage("Error!","Type '"..tp.." not found",COLOR_LIGHTRED) | ||
| if typename == nil then | ||
| dialog.showInputPrompt("Class type","Input class type or leave empty for auto and '*' for new ptr type auto:",COLOR_WHITE,"",self:callback("insertNew")) |
Member
Author
There was a problem hiding this comment.
This is too verbose and unclear.
Member
Author
|
Ready to merge now IMHO. Unless someone has any more suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to insert ints and other simple types. Also allow inserting of same base type as the container.
Waiting for better message ideas. Would like to merge before next release.