Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edit Field long lines changing text cursor behaviour #5227

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

wiktor-obrebski
Copy link
Contributor

Fix EditField long lines cursor behaviour described in this issue:

The scenario requires a couple of commands in gui/launcher history: (e.g.)
:lua print'jh 0123456789 0123456789 0123456789 jl'(the "long" entry)
extend the string (or shrink the window) as necessary so that it is longer
than the gui/launcher command line is wide
gui/gm-unit (the "short" entry)
Then,
Alt-s to focus the search field,
type jj to find the long entry,
Ctrl-u to clear the search field,
type unit to find the short entry,
Esc to go back to the command line field.
The command line EditField looks like it is empty with just a cursor. The short entry is
there, but it is "scrolled" out of view to the left. Moving the cursor to the
left will start to reveal the short entry.

@wiktor-obrebski wiktor-obrebski force-pushed the fix/edit-field-long-lines branch from 3e211b8 to 3071db5 Compare January 30, 2025 07:19
@myk002 myk002 merged commit c1ddbde into DFHack:develop Jan 30, 2025
14 checks passed
myk002 added a commit that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants