Skip to content

Commit

Permalink
[6172] Remove redundant border style
Browse files Browse the repository at this point in the history
  • Loading branch information
darokel authored and d-a-v-e committed Nov 13, 2023
1 parent 8281d4c commit 079f428
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 7 deletions.
4 changes: 0 additions & 4 deletions app/assets/stylesheets/application.scss
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ $mobile-big-end: 501px;
float: right;
}

.app-header--full-border {
border-bottom-color: $govuk-brand-colour;
}

.govuk-error-summary__list {
color: $govuk-error-colour;
font-weight: 700;
Expand Down
2 changes: 1 addition & 1 deletion app/components/header/view.html.erb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<header class="govuk-header app-header--full-border app-header__env--<%= Settings.environment.name %>" role="banner" data-module="govuk-header">
<header class="govuk-header app-header__env--<%= Settings.environment.name %>" role="banner" data-module="govuk-header">
<div class="govuk-header__container govuk-width-container">
<div class="govuk-header__logo app-header__logo">
<%= govuk_link_to "/", class: "govuk-header__link govuk-header__link--homepage" do %>
Expand Down
11 changes: 10 additions & 1 deletion docs/setup-development.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,16 @@ Add a file to config/settings called development.local.yml containing the follow
## Start the server
To start all the processes run:
To start all the processes you'll need to first create a local `Procfile.dev` file with the following:

```
web: bin/rails server -p 3000
js: yarn build --watch
css: yarn build:css --watch
worker: bundle exec sidekiq -t 25 -C config/sidekiq.yml
```
Then run the following command:
```bash
./bin/dev
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<link rel="stylesheet" media="all" href="stylesheets/style.css">
</head>
<body class="govuk-template__body">
<header class="govuk-header govuk-!-display-none-print app-header--production app-header--full-border app-header--wide-logo" role="banner" data-module="govuk-header">
<header class="govuk-header govuk-!-display-none-print app-header--production app-header--wide-logo" role="banner" data-module="govuk-header">
<div class="govuk-header__container govuk-width-container">
<div class="govuk-header__logo">
<a class="govuk-header__link govuk-header__link--homepage" href="https://www.gov.uk/">
Expand Down

0 comments on commit 079f428

Please sign in to comment.