Repository navigation
Deploy to per-environment container apps from the workflow - #15
Merged
Merged
Conversation
Build now only pushes an image from main and hands it to deploy.yml for dev. Other environments are deployed by running deploy.yml with an existing image tag, so the image promoted is the one already tested in dev rather than a fresh build.
The Dockerfile runs its own publish, so the output of this step was never used.
The image job only runs once tests pass and is the only job granted packages: write, so PR runs no longer get registry write access. Test and Docker failures now show up as separate checks, and the image job no longer waits for the ledger database service to start.
The image is built into the local Docker store and pushed in its own step, so PR runs show the login and push as skipped rather than a green build-and-push step that never pushed.
After dev, the same image is deployed to preprod then prod. Both jobs wait on the approval rules configured on their GitHub environments, so each run shows how far that image has been promoted.
SummarySummary
CoverageSchoolAccount.CollectNotifications - 88.1%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploys the Collect Notifications job to per-environment Azure Container Apps Jobs.
school-account-dev-team(enforced by the GitHub environments, which also only accept deployments from main). Each run shows how far its image got.dotnet publishstep.