Generic phpdoc template incorrect

[vitkutny]

Source code from Doctrine ORM:

namespace Doctrine\ORM;

interface EntityManagerInterface extends ObjectManager
{
    /**
     * {@inheritDoc}
     *
     * @psalm-param class-string<T> $className
     *
     * @psalm-return EntityRepository<T>
     *
     * @template T of object
     */
    public function getRepository($className);

Method call:

$this->entityManager->getRepository(MyEntity::class)->findBy($criteria);

Actual results:

Call to unknown method: MyEntity::findBy() – PHP(PHP0418)

Expected result: no errors – expecting getRepository return value to by of type EntityRepository<MyEntity> instead of MyEntity itself

[jakubmisek]

Thank you. I'm trying doctrine/orm v2.18:

and it works as expected;

Can you check where the editor guesses the wrong type exactly? Or create a complete small test case. Do you have the correct function signature in tooltip?

[vitkutny]

Maybe it works differently in VS code <=> VS – if your screenshots are from VS ? I am using VS code extension. Tried upgrading doctrine/orm and reinstalling php extension which didnt help.

[jakubmisek]

Isn't there an "ide_helper" with some incorrectly generated stubs?

[vitkutny]

Found the source of this issue! We are using nettrine/orm which integrates Doctrine into Nette framework https://github.com/contributte/doctrine-orm

There is phpstorm metadata file .phpstorm.meta.php – everytihing works correctly when deleted https://github.com/contributte/doctrine-orm/blob/master/.phpstorm.meta.php

It was added for phpstorm to be able to detect dynamic return type, but looking at the file its wrong that the definition of find and getRepository is the same. Dont know if this is working correctly in phpstorm, or getRepository meta should be deleted / edited

contributte/doctrine-orm@b6e683a

file was created based on PR contributte/doctrine-orm#49

[jakubmisek]

Awesome! I thought it would be something like this.

It seems the .phpstorm.meta.php file is simply incorrect, and it does not work in PhpStorm either (PhpStorm is just much quieter about errors, so people may not notice). I suggest reporting the issue to them as well.