Removed enum from color class and temporar fix to access constant fro… #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m text_mobjects, fix #2
amandakrohn
reviewed
Mar 6, 2022
manim/mobject/text/text_mobject.py
Outdated
| else: | ||
| return Colors[col.lower()].value | ||
| testCol = col.upper() | ||
| return globals()[testCol] |
There was a problem hiding this comment.
I'm not sure if using globals() is good practice? We should instead store all the colors in some data structure and use that one. As suggested by @Darylgolden:
Regarding the first point: I've realized that random_color relies on an object containing information on all preset colors, so perhaps it might not be desirable to remove such an object entirely. Perhaps Colors should be a list? I'm not sure.
There was a problem hiding this comment.
Good point! I've changed how the values can be accessed now
BrorSebastianSjovald
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the enums from color.py and made changes to files still using the enums instead of constants.
Closes: #2 #3