Skip to content

Conversation

@BrorSebastianSjovald
Copy link

@BrorSebastianSjovald BrorSebastianSjovald commented Mar 7, 2022

Functionality already implemented in the colour module should be deprecated and fixed. This PR adds warnings to all relevant functions with the text "refer to colour module for conversions".

Closes #1

Copy link

@ludwigjo ludwigjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ludwigjo ludwigjo merged commit 288951b into refactor/color Mar 7, 2022
BrorSebastianSjovald added a commit that referenced this pull request Mar 9, 2022
* Added deprecation warnings for color conversions, feat #1

* Update and remove unecessary warnings, fix #1

* Added more specific deprecation warnings

* Removed warnings from functions that are not in `colour` module

* Fixed deprecation warning in `color_to_rgb`, fix #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants