fixed potential issue if charptr was just {0}

DASPELLER4 · Sep 8, 2022 · fe80f6a · fe80f6a
1 parent 3c65b37
commit fe80f6a
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/include/string.h b/include/string.h
@@ -62,13 +62,11 @@ string_t *defineEmptyString(){
 }
 
 string_t *defineStringFromCharPtr(char *start, short ifToFreeOrNotToFreeThatIsTheQuestion){
-	string_t *string = malloc(sizeof(string_t));
-	string->value = start[0];
-	string->next = NULL;
-	start++; // woop woop finally get to use pointer arithmetic
+	string_t *string = NULL;
 	appendCharPtr(start, string, ifToFreeOrNotToFreeThatIsTheQuestion);
-	if(!ifToFreeOrNotToFreeThatIsTheQuestion)
-		start--;
+	if(ifToFreeOrNotToFreeThatIsTheQuestion){
+		free(start);
+	}
 	return string;
 }