DD-422 posting same license error #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @POST |
There was a problem hiding this comment.
Why is this section of code deleted? Doesn't seem to have anything to do with licenses.
| @@ -936,27 +891,13 @@ public Response listBuiltinRoles() { | |||
| } | |||
| } | |||
|
|
|||
| @DELETE | |||
There was a problem hiding this comment.
@JingMa87 : it seems you are removing some parts of the code that have nothing to do with licenses. Please, have another look.
|
@janvanmansum I merged the branches. Also, how come there was a merge conflict in the first place? |
PaulBoon
pushed a commit
to PaulBoon/dataverse
that referenced
this pull request
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: It fixes the 500 error when you post the same license twice.
Which issue(s) this PR closes: DD-422
Closes #
Special notes for your reviewer: N/A
Suggestions on how to test this: Post the same license twice.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: No
Additional documentation: N/A