Merge pull request MaterializeInc#14161 from mjibson/pgtest-params

pgtest: test invalid param binding

src/environmentd/tests/pgwire.rs

@@ -28,7 +28,7 @@ use tokio::runtime::Runtime;
 use tokio::sync::mpsc;
 
 use mz_ore::collections::CollectionExt;
-use mz_ore::{assert_contains, task};
+use mz_ore::task;
 use mz_pgrepr::{Numeric, Record};
 
 use crate::util::PostgresErrorExt;
@@ -43,11 +43,6 @@ fn test_bind_params() -> Result<(), Box<dyn Error>> {
     let server = util::start_server(config)?;
     let mut client = server.connect(postgres::NoTls)?;
 
-    match client.query("SELECT ROW(1, 2) = $1", &[&42_i32]) {
-        Ok(_) => panic!("query with invalid parameters executed successfully"),
-        Err(err) => assert_contains!(format!("{:?}", err.source()), "WrongType"),
-    }
-
     match client.query("SELECT ROW(1, 2) = $1", &[&"(1,2)"]) {
         Ok(_) => panic!("query with invalid parameters executed successfully"),
         Err(err) => assert!(err.to_string().contains("no overload")),

test/pgtest/params.pt

@@ -0,0 +1,14 @@
+# Test that invalid query params are rejected.
+
+send
+Parse {"query": "SELECT $1 + 1"}
+Bind {"values": ["a"]}
+Sync
+----
+
+until err_field_typs=S
+ReadyForQuery
+----
+ParseComplete
+ErrorResponse {"fields":[{"typ":"S","value":"ERROR"}]}
+ReadyForQuery {"status":"I"}