Skip to content

Commit

Permalink
version consistency: ignore min/max errors
Browse files Browse the repository at this point in the history
  • Loading branch information
def- committed Dec 22, 2023
1 parent b3ef64d commit 873f0b7
Showing 1 changed file with 13 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@

MZ_VERSION_0_77_0 = MzVersion.parse_mz("v0.77.0")
MZ_VERSION_0_78_0 = MzVersion.parse_mz("v0.78.0")
MZ_VERSION_0_81_0 = MzVersion.parse_mz("v0.81.0")


class VersionConsistencyIgnoreFilter(GenericInconsistencyIgnoreFilter):
Expand Down Expand Up @@ -96,6 +97,18 @@ def shall_ignore_expression(
):
return YesIgnore("Accepted: no order explicitly specified")

if (
self.lower_version < MZ_VERSION_0_81_0 <= self.higher_version
and expression.matches(
partial(
matches_fun_by_any_name,
function_names_in_lower_case={"min", "max"},
),
True,
)
):
return YesIgnore("Implemented min/max for interval and time types in 24007")

return super().shall_ignore_expression(expression, row_selection)

def _is_any_date_time_expression(self, expression: Expression) -> bool:
Expand Down

0 comments on commit 873f0b7

Please sign in to comment.