some cleanup in the Lanczos files #726
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h _ followed by upper case
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #726 +/- ##
==========================================
+ Coverage 32.35% 35.34% +2.99%
==========================================
Files 215 215
Lines 36363 33014 -3349
Branches 14597 13136 -1461
==========================================
- Hits 11764 11670 -94
+ Misses 22659 19430 -3229
+ Partials 1940 1914 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IvanaGyro
approved these changes
Dec 5, 2025
| UniTensor _invert_biCGSTAB(LinOp *Hop, const UniTensor &b, const UniTensor &Tin, const int &k, | ||
| const double &CvgCrit = 1.0e-12, | ||
| const unsigned int &Maxiter = 10000) { | ||
| static UniTensor invert_biCGSTAB_internal(LinOp *Hop, const UniTensor &b, const UniTensor &Tin, |
Collaborator
There was a problem hiding this comment.
Using unnamed namespace for internal linkage is a preferred style in modern C++.
Example: https://google.github.io/styleguide/cppguide.html#Internal_Linkage
|
|
||
| //_Lanczos_Exp_Ut_positive(out, Hop, v0, _cvgcrit, Maxiter, verbose); | ||
| _Lanczos_Exp_Ut(out, Hop, v0, tau, _cvgcrit, Maxiter, verbose); | ||
| // Lanczos_Exp_Ut_internal_positive(out, Hop, v0, _cvgcrit, Maxiter, verbose); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids function names starting with _ followed by upper case