Skip to content

fix(ptr): replace deprecated Boost atomic count - #1166

Open
IvanaGyro wants to merge 1 commit into
masterfrom
codex/fix-1121-std-atomic-refcount
Open

fix(ptr): replace deprecated Boost atomic count#1166
IvanaGyro wants to merge 1 commit into
masterfrom
codex/fix-1121-std-atomic-refcount

Conversation

@IvanaGyro

@IvanaGyro IvanaGyro commented Aug 2, 2026

Copy link
Copy Markdown
Member

Problem

intrusive_ptr_base.hpp includes Boost's deprecated boost/detail/atomic_count.hpp, and tons of deprecation warning occupy the CI logs.

Fix

Replace the internal reference counter with std::atomic<int> while preserving the existing intrusive-pointer reference-count operations.

Testing

Not run locally at request; CI will verify.

Closes #1121.

Co-Authored-By: Codex <noreply@openai.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@IvanaGyro
IvanaGyro marked this pull request as ready for review August 2, 2026 16:01
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.92%. Comparing base (a969a66) to head (0799293).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1166   +/-   ##
=======================================
  Coverage   67.92%   67.92%           
=======================================
  Files         208      208           
  Lines       22355    22355           
  Branches       72       72           
=======================================
  Hits        15185    15185           
  Misses       7148     7148           
  Partials       22       22           
Flag Coverage Δ
cpp 67.99% <ø> (ø)
python 63.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
C++ backend 67.99% <ø> (ø)
Python bindings ∅ <ø> (∅)
Python package 63.96% <ø> (ø)
Files with missing lines Coverage Δ
include/intrusive_ptr_base.hpp 16.66% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a969a66...0799293. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boost/detail/atomic_count.hpp is deprecated

1 participant