RunOnThreadPool: cancelling at the wrong time prevents returning to the main thread

[Tomcc]

Hi! My game's test suite was hitting a ton of random failures to return to the main thread (which in turn caused Unity exceptions), and I think I traced it down to UniTask itself.

UniTask.RunOnThreadPool (all versions) currently looks like this:

        public static async UniTask RunOnThreadPool(Action<object> action, object state, bool configureAwait = true, CancellationToken cancellationToken = default)
        {
            cancellationToken.ThrowIfCancellationRequested();

            await UniTask.SwitchToThreadPool();

            cancellationToken.ThrowIfCancellationRequested();

            if (configureAwait)
            {
                try
                {
                    action(state);
                }
                finally
                {
                    await UniTask.Yield();
                }
            }
            else
            {
                action(state);
            }

            cancellationToken.ThrowIfCancellationRequested();
        }

if the timing aligns just right, the second cancellationToken.ThrowIfCancellationRequested(); will throw an exception on the threadpool and prevent UniTask.Yield() from ever running.
If the caller handles cancellations or has its own finally's, everything after this will run on the wrong thread.

I made a pretty simple change that moves the cancellation check inside the try itself.

Some versions of RunOnThreadPool had a cancellationToken.ThrowIfCancellationRequested(); inside the finally before the Yield which would cause the same problem, so I removed those as well.

Thanks for the great library btw!

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[Tomcc]

Hi, we're still using this fix ourselves, and I think this is a fairly serious bug... Is this repo abandoned?