add overload, and change the order of arguments #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, it seems good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and Modify Overloads for ToWritableNotifyCollectionChanged
Changes Overview
Added methods to
Filtablethat can operate without theconverterparameter that exists inNonFilteredStandardized parameter order between
FiltableandNonFiltermethodsWritableViewChangedEventHandler<T, TView>?, ICollectionEventDispatcher?NotifyCollectionChangedSynchronizedViewList, reversing this order might be more appropriateFixed issue where
converterparameter wasn't being passed inNonFilterFixed issue where
collectionEventDispatcherwasn't being passed inFiltableTechnical Details
These modifications improve the consistency and functionality of the
ToWritableNotifyCollectionChangedmethod overloads, ensuring better usability and proper parameter handling across different scenarios.Related Issues
Please review and provide feedback on these changes.