Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to emit INotifyCollectionChanged.OnPropertyChanged #27

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix to emit INotifyCollectionChanged.OnPropertyChanged #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix to emit INotifyCollectionChanged.OnPropertyChanged
  • Loading branch information
@hadashiA
hadashiA committed Feb 16, 2024
commit 600a300d902b80e4125c746e94ab53edf62fac4b
6 changes: 3 additions & 3 deletions sandbox/ConsoleApp/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
class ViewModel
{
public int Id { get; set; }
public string Value { get; set; }
public string Value { get; set; } = default!;
}

class HogeFilter : ISynchronizedViewFilter<int, ViewModel>
Expand All @@ -65,8 +65,8 @@ public void WhenFalse(int value, ViewModel view)
}

public void OnCollectionChanged(
ChangedKind changedKind,
int value,
ChangedKind changedKind,
int value,
ViewModel view,
in NotifyCollectionChangedEventArgs<int> eventArgs)
{
Expand Down
2 changes: 2 additions & 0 deletions src/ObservableCollections/Internal/NotifyCollectionChangedSynchronizedView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,11 @@ public void OnCollectionChanged(ChangedKind changedKind, T value, TView view, in
{
case ChangedKind.Add:
CollectionChanged?.Invoke(this, new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Add, view, eventArgs.NewStartingIndex));
PropertyChanged?.Invoke(this, CountPropertyChangedEventArgs);
return;
case ChangedKind.Remove:
CollectionChanged?.Invoke(this, new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Remove, view, eventArgs.OldStartingIndex));
PropertyChanged?.Invoke(this, CountPropertyChangedEventArgs);
break;
case ChangedKind.Move:
CollectionChanged?.Invoke(this, new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Move, view, eventArgs.NewStartingIndex, eventArgs.OldStartingIndex));
Expand Down
Loading