Fix BrotliCompressor.CopyToAsync buffer is not enough#249
Merged
Conversation
Contributor
Author
|
Here is the code to reproduce the issue. I have written a slightly shortened version, const string path1 = "/path/to/test.compressed";
var inputBytes = await File.ReadAllBytesAsync(path1);
System.Console.WriteLine($"Compressed file size (input) : {inputBytes.Length}");
var decompressor = new BrotliDecompressor();
var inputDecompressedBytes = decompressor.Decompress(inputBytes);
System.Console.WriteLine($"Decompressed size (input) : {inputDecompressedBytes.Length}");
var inputDeserialized = MemoryPackSerializer.Deserialize<TradeLog>(inputDecompressedBytes)!;
System.Console.WriteLine($"Decompressed data count (input) : {inputDeserialized.Data.Count}");
decompressor.Dispose();
System.Console.WriteLine("---------------");
var compressor = new BrotliCompressor(CompressionLevel.SmallestSize);
MemoryPackSerializer.Serialize(compressor, inputDeserialized);
// var buffer = new ArrayBufferWriter<byte>(inputBytes.Length);
// compressor.CopyTo(buffer);
var memoryStream = new MemoryStream(inputBytes.Length);
await compressor.CopyToAsync(memoryStream);
memoryStream.Flush();
memoryStream.Seek(0, SeekOrigin.Begin);
// System.Console.WriteLine($"Compressed size (serialized) : {buffer.WrittenSpan.Length}");
System.Console.WriteLine($"Compressed size (serialized) : {memoryStream.Length}");
compressor.Dispose();
var decompressor2 = new BrotliDecompressor();
var decompressedBytes = decompressor.Decompress(memoryStream.ToArray());
System.Console.WriteLine($"Decompressed size (serialized) : {decompressedBytes.Length}");
var deserialized = MemoryPackSerializer.Deserialize<TradeLog>(decompressedBytes)!;
System.Console.WriteLine($"Decompressed data count (serialized) : {deserialized.Data.Count}");
decompressor2.Dispose();test.compressed data is available from the above comment. |
hadashiA
commented
Mar 15, 2024
| } | ||
|
|
||
| // call BrotliEncoderOperation.Finish | ||
| var finalStatus = encoder.Compress(ReadOnlySpan<byte>.Empty, buffer, out var consumed, out var written, isFinalBlock: true); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#243
BrotoliEncoder.Compress seems to return
OperationState.DestinationTooSmalleven when the destination buffer is short.If the length of one BufferSegment is very large (more than the bufferSize parameter), finalState was DestinationTooSmall, the method would complete.
( In #243, MemoryStream is used).