Skip to content

Commit

Permalink
Remove __len__ method from DGLGraph (dmlc#2902)
Browse files Browse the repository at this point in the history
* Update heterograph.py

* remove unit tests

* replace tutorial
  • Loading branch information
BarclayII authored May 11, 2021
1 parent 70695ff commit 103444c
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
7 changes: 0 additions & 7 deletions python/dgl/heterograph.py
Original file line number Diff line number Diff line change
Expand Up @@ -2447,13 +2447,6 @@ def num_edges(self, etype=None):
else:
return self._graph.number_of_edges(self.get_etype_id(etype))

def __len__(self):
"""Deprecated: please directly call :func:`number_of_nodes`
"""
dgl_warning('DGLGraph.__len__ is deprecated.'
'Please directly call DGLGraph.number_of_nodes.')
return self.number_of_nodes()

@property
def is_multigraph(self):
"""Return whether the graph is a multigraph with parallel edges.
Expand Down
2 changes: 0 additions & 2 deletions tests/compute/test_graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ def test_query():
def _test_one(g):
assert g.number_of_nodes() == 10
assert g.number_of_edges() == 20
assert len(g) == 10

for i in range(10):
assert g.has_node(i)
Expand Down Expand Up @@ -131,7 +130,6 @@ def _test(g):
def _test_csr_one(g):
assert g.number_of_nodes() == 10
assert g.number_of_edges() == 20
assert len(g) == 10

for i in range(10):
assert g.has_node(i)
Expand Down
2 changes: 1 addition & 1 deletion tutorials/models/1_gnn/4_rgcn.py
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ def forward(self, g):
g.edata.update({'rel_type': edge_type, 'norm': edge_norm})

# create model
model = Model(len(g),
model = Model(g.num_nodes(),
n_hidden,
num_classes,
num_rels,
Expand Down

0 comments on commit 103444c

Please sign in to comment.