refactor multipleItemRvAdapter #2139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. remove multipleItemRvAdapter clickListener
2. Replace reflections with native methods
Contributor
|
@AllenCoder 我正在修改，支持注解或者重写getLayout()方法或getViewType()方法返回对应的layoutId和viewType，至于点击事件冲突的问题，我这边加了判断如果设置了onItemClickListener或者onItemLongClickListener则不会回调到provider中，这样用户可以选择其中一种方法设置点击事件 |
Collaborator
Author
|
1 。点击事件，没有必要单独抽出一个写法，会导致原来的用户对点击事件的理解变得混乱，应该继续统一使用原来的点击写法，所以我的pr里，把点击的写法都移除掉了。 |
Contributor
|
@AllenCoder 如果点击事件都放在OnItemClickListener中的话，如果不同条目的点击事件不同，那不是还要在回调中做很多判断，所以我觉得两种方式用户可以任选其一，如果条目的点击事件都是相同，那么他通过setOnItemClickListener在回调中处理，如果他想在不同的ItemProvider中做不同的点击处理，那么他重写ItemProvider中的onClick方法，在对应的ItemProvider中点击处理，我觉得这样规范一点。 |
…dapterHelper # Conflicts: # app/src/main/java/com/chad/baserecyclerviewadapterhelper/adapter/provider/ImgItemProvider.java # app/src/main/java/com/chad/baserecyclerviewadapterhelper/adapter/provider/TextImgItemProvider.java # app/src/main/java/com/chad/baserecyclerviewadapterhelper/adapter/provider/TextItemProvider.java # library/src/main/java/com/chad/library/adapter/base/MultipleItemRvAdapter.java # library/src/main/java/com/chad/library/adapter/base/provider/BaseItemProvider.java # library/src/main/java/com/chad/library/adapter/base/util/ProviderDelegate.java
…dapterHelper # Conflicts: # app/src/main/java/com/chad/baserecyclerviewadapterhelper/adapter/provider/ImgItemProvider.java # app/src/main/java/com/chad/baserecyclerviewadapterhelper/adapter/provider/TextImgItemProvider.java # app/src/main/java/com/chad/baserecyclerviewadapterhelper/adapter/provider/TextItemProvider.java # library/src/main/java/com/chad/library/adapter/base/MultipleItemRvAdapter.java # library/src/main/java/com/chad/library/adapter/base/provider/BaseItemProvider.java # library/src/main/java/com/chad/library/adapter/base/util/ProviderDelegate.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.refactor multipleItemRvAdapter
2. remove multipleItemRvAdapter clickListener
3.Deprecated interface ItemProvideTag
4. Replace reflections with native methods