fixed the issue #1928 regarding onItemSwiped callback. #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@AllenCoder please take a look. and tell me if there anything I can do to merge my pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using setOnItemSwipeListener#onItemSwiped as in sample application I noticed that onItemSwiped is called before the swiped item is deleted from the data list.
looking at library code it turns out the that in BaseItemDraggableAdapteronItemSwiped#onItemSwiped is called before remove mData.remove(pos);
which make the callback mostly useless if you want to make anything with the updated data.
I'm suggesting moving onItemSwiped at the end of the method.
I have tried it and every this seems to be working fine.
I have made a pull request containing my solution.